-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raising a better exception message from Azure Monitoring http response #597
Raising a better exception message from Azure Monitoring http response #597
Conversation
…ring is returning a JSON Payload in its Response
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr597 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-agent-scraper-pr597 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env-file C:/Promitor/az-mon-auth.creds \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr597 You can find a CI version of our Helm chart on hub.helm.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks - Just a small suggestion.
Co-Authored-By: Tom Kerkhove <kerkhove.tom@gmail.com>
Co-Authored-By: Tom Kerkhove <kerkhove.tom@gmail.com>
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr597 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-agent-scraper-pr597 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env-file C:/Promitor/az-mon-auth.creds \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr597 You can find a CI version of our Helm chart on hub.helm.sh |
Thank you very much for your contribution @Mimetis! |
Update
ScrapeAsync
method to raise better exception when Azure monitoring is returning a JSON Payload in its Response.The json payload looks like this:
From the
Microsoft.Azure.Management.Monitor.Fluent
SDK, we have a wrapped exceptionErrorResponseException
used here to get the detailed message